Add explicit serialization support for Obs and Ops binding classes for H distribution #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
…lane-lightning into update/pickle_bindings
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
==========================================
+ Coverage 98.18% 98.38% +0.19%
==========================================
Files 10 146 +136
Lines 1210 19324 +18114
==========================================
+ Hits 1188 19011 +17823
- Misses 22 313 +291 ☔ View full report in Codecov by Sentry. |
mlxd
force-pushed
the
update/pickle_bindings
branch
from
16c5b99 to
b6f8c10
Compare
…lane-lightning into update/pickle_bindings
|
Note: LUMI data collected using the current changes as of the latest commit. |
mlxd
changed the title
|
Currently pausing development until a full integration strategy has been defined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR adds explicit support for serialization and pickling of C++ bound classes in the Lightning backends. Additional functionality is added to validate this supports with scaled distribution of the pickled work using mpi4py.
Description of the Change: Enables explicit pickling support to C++ bound classes. Unlocks support for mpi4py concurrent futures API evaluation of pickled classes with forward pass and adjoint gradients of H.
Benefits: Allows immediate scaling evaluations of forward pass and adjoint gradients of Hamiltonians with LightningKokkos.
Possible Drawbacks: Functionality integration requires subtle architectural changes to better integrate with other backends in ecosystem.
Related GitHub Issues:
Shortcut Stories:
[sc-53909]